[WIP][Parser][SR-711] Couple "expected declaration" Diagnose With A Note #1276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't actually think that message makes sense for these diagnostics, though. |
dduan
changed the title
dduan
changed the title
|
It would also be great to expand the primary message from "expected declaration" to "expected declaration in body of type" or something like that. |
[AST] rename some DeclContext isXXX methods to getAsXXX
dduan
force-pushed
the
SR771_stmt_in_type_body
branch
from
d9d5e3e to
7f3efd2
Compare
MaxDesiatov
added a commit
that referenced
this pull request
Oct 19, 2020
[pull] swiftwasm from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in SR-711, when an (unexpected) statement appears in a type declaration, we note the beginning of the declaration in addiction to the existing diagnostic.