PMOpt refactoring before big changes #12780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These APIs make it easy to create borrow/end_borrow operations in a pass that has to handle both ownership and non-ownership SIL. rdar://31521023
…ges. rdar://31521023
In non-ownership SIL, PMOpt did not need to distinguish in between destructive and non-destructive sub element extraction. This allowed PMOpt to just use the "non-destructive" sub element (i.e. extractSubElement) everywhere. In preparation for introducing this distinction (and a destructive sub element extractor), rename extractSubElement to be nonDestructivelyExtractSubElement for clarity. NFC. rdar://31521023
…thod flow better when read. NFC. rdar://31521023
This is in preparation for adding the distinction of destructive vs non-destructive extracts. NFC. rdar://31521023
This is to ensure that when I add the destructive code when ownership is enabled, the non-ownership variant doesn't break. I have to move the rest of the pipeline to -Onone at the same time. Once that is done, I will remove more code. NFC. rdar://31521023
|
@swift-ci test |
|
@swift-ci test source compatibility suite |
|
@swift-ci test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a bunch of changes that are all NFC that I was able to split off from the larger commit that updates PMOpt for ownership. This will enable us to separate the adding/validation of new functionality from the necessary refactoring which will ease committing this into tree.
rdar://31521023