Rename "build configurations" to "conditional compilation blocks". #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...because "build configuration" is already the name of an Xcode feature. - '#if' et al are "conditional compilation directives". - The condition is a "conditional compilation expression", or just "condition" if it's obvious. - The predicates are "platform conditions" (including 'swift(>=...)') - The options set with -D are "custom conditional compilation flags". (Thanks, Kevin!) I left "IfConfigDecl" as is, as well as SourceKit's various "BuildConfig" settings because some of them are part of the SourceKit request format. We can change these in follow-up commits, or not. rdar://problem/19812930
Also move a Parse test that's really about conditional compilation directives into the new folder.
|
@swift-ci Please test |
|
This approach makes sense to me. Thank you for fixing the diagnostics to be more specific instead of referring to "conditional compilation blocks" mechanically. |
|
Text in source kit request format is expensive to change. I am fine with leaving as it is. |
|
Pretty sure that's not my failure, merging anyway! |
jrose-apple
added a commit
that referenced
this pull request
Feb 12, 2016
Rename "build configurations" to "conditional compilation blocks".
MaxDesiatov
added a commit
that referenced
this pull request
Oct 19, 2020
Resolve conflicts with master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...because "build configuration" is already the name of an Xcode feature.
#ifet al are "conditional compilation directives".swift(>=...))I left "IfConfigDecl" as is, as well as SourceKit's various "BuildConfig" settings because some of them are part of the SourceKit request format. We can change these in follow-up commits, or not. (cc @akyrtzi and @nkcsgexi)
rdar://problem/19812930