[SR-6361] Fix Data.withUnsafeMutableBytes() for slices with length < range.lowerBound #12898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashabelonogov
force-pushed
the
sashabelonogov/SR-6361
branch
4 times, most recently
from
98f9396 to
d9e0e56
Compare
|
@swift-ci please test and merge |
|
Thank you very much for following up on this! |
sashabelonogov
force-pushed
the
sashabelonogov/SR-6361
branch
from
d9e0e56 to
bf56b09
Compare
|
@phausler swift-ci was unable to find macOS machine, maybe it's related to the maintenance that happened at 6pm PST, can we try again? |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to overlay to match changes done to Data.swift that are approved in PR to swift-corelibs-foundation requested by @phausler:
swiftlang/swift-corelibs-foundation#1314
This PR will fix
fatal error: UnsafeMutableRawBufferPointer with negative countwhen usingData.withUnsafeMutableBytes()for slices with length < range.lowerBoundResolves SR-6361.
Thank you!