Minor clean-up of -assert-config option handling. #1295
Conversation
* Replace 'Fast' with 'Unchecked' everywhere. * Update the help text to specify DisableReplacement rather than Replacement and to document Unchecked. * Simplify tests slightly and add a tests for Unchecked.
|
@swift-ci Please test @aschwaighofer @jrose-apple Is there any reason -assert-config=Fast was left undocumented or any real chance changing it to -assert-config=Unchecked will break anything at this point? |
|
In theory we're not supposed to change Driver options; they're part of the compiler's stable interface. In practice I think this flag is rare enough that it's okay…but then I'd rather take it out of the driver altogether, and just make it a frontend option. (Either we think it's important for users, or we don't.) @gribozavr, any thoughts? |
|
We could keep a backwards compatibility alias if you want to be extra safe, but I believe this particular option won't cause issues. |
|
I considered making it a frontend option but then noticed posts around the web talking about using --assert-config=Debug with release builds and figured that would probably break someone. I couldn't find any examples of people talking about using --assert-config=Fast, perhaps because it wasn't documented. |
Minor clean-up of -assert-config option handling.
|
Okay, let's try to never do this again. :-) |
Replacement and to document Unchecked.