[ConstraintSystem] Improve type parameter requirement locators #13047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DougGregor does this seem reasonable to you? |
DougGregor
reviewed
Nov 27, 2017
lib/Sema/ConstraintLocator.h
Outdated
| @@ -319,6 +323,11 @@ class ConstraintLocator : public llvm::FoldingSetNode { | |||
| assert(getAssociatedType() == decl); | |||
| } | |||
|
|
|||
| PathElement(const swift::Requirement &req, unsigned pos) | |||
There was a problem hiding this comment.
req isn't actually used here; can you instead add a static PathElement getTypeRequirement(unsigned position)?
When opening generic types with type parameter requirements, add information about requirement location to the locator of each generated constraint to make it easier to extract such information if needed.
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening generic types with type parameter requirements,
add information about requirement location to the locator of each
generated constraint to make it easier to extract such information
if needed.