Skip to content

IRGen: Don't emit bodies of public_external transparent functions #13052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

slavapestov
Copy link
Contributor

This is another holdover from when transparent functions had
special treatment.

This is another holdover from when transparent functions had
special treatment.
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test compiler performance

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 824b1f3

@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 824b1f3

@slavapestov
Copy link
Contributor Author

@swift-ci Please test Linux

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 824b1f3

@swift-ci
Copy link
Contributor

Build comment file:

Summary for master smoketest

No regressions above thresholds

Debug

debug brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 23,300,060 23,299,108 -952 -0.0%
time.swift-driver.wall 31.6s 31.6s 37.5ms 0.12%

debug detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 47,780 47,780 0 0.0%
AST.NumLoadedModules 6,369 6,369 0 0.0%
AST.NumTotalClangImportedEntities 133,186 133,186 0 0.0%
AST.NumUsedConformances 2,715 2,715 0 0.0%
IRModule.NumIRBasicBlocks 65,651 65,639 -12 -0.02%
IRModule.NumIRFunctions 32,989 32,987 -2 -0.01%
IRModule.NumIRGlobals 36,462 36,462 0 0.0%
IRModule.NumIRInsts 702,969 702,823 -146 -0.02%
IRModule.NumIRValueSymbols 59,799 59,797 -2 -0.0%
LLVM.NumLLVMBytesOutput 23,300,060 23,299,108 -952 -0.0%
SILModule.NumSILGenFunctions 14,642 14,642 0 0.0%
SILModule.NumSILOptFunctions 25,716 25,716 0 0.0%
Sema.NumConformancesDeserialized 144,780 144,780 0 0.0%
Sema.NumConstraintScopes 456,640 456,640 0 0.0%
Sema.NumDeclsDeserialized 932,278 932,278 0 0.0%
Sema.NumDeclsValidated 28,449 28,449 0 0.0%
Sema.NumFunctionsTypechecked 27,343 27,343 0 0.0%
Sema.NumGenericSignatureBuilders 37,135 37,135 0 0.0%
Sema.NumLazyGenericEnvironments 197,561 197,561 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 19,492 19,492 0 0.0%
Sema.NumLazyIterableDeclContexts 155,841 155,841 0 0.0%
Sema.NumTypesDeserialized 1,000,561 1,000,561 0 0.0%
Sema.NumTypesValidated 97,068 97,068 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 28,808,960 28,808,960 0 0.0%
time.swift-driver.wall 67.9s 67.9s 29.1ms 0.04%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 7,421 7,421 0 0.0%
AST.NumLoadedModules 227 227 0 0.0%
AST.NumTotalClangImportedEntities 22,601 22,601 0 0.0%
AST.NumUsedConformances 2,721 2,721 0 0.0%
IRModule.NumIRBasicBlocks 61,830 61,830 0 0.0%
IRModule.NumIRFunctions 26,568 26,568 0 0.0%
IRModule.NumIRGlobals 34,118 34,118 0 0.0%
IRModule.NumIRInsts 583,861 583,861 0 0.0%
IRModule.NumIRValueSymbols 54,268 54,268 0 0.0%
LLVM.NumLLVMBytesOutput 28,808,960 28,808,960 0 0.0%
SILModule.NumSILGenFunctions 10,842 10,842 0 0.0%
SILModule.NumSILOptFunctions 19,739 19,739 0 0.0%
Sema.NumConformancesDeserialized 81,667 81,667 0 0.0%
Sema.NumConstraintScopes 436,386 436,386 0 0.0%
Sema.NumDeclsDeserialized 137,279 137,279 0 0.0%
Sema.NumDeclsValidated 17,632 17,632 0 0.0%
Sema.NumFunctionsTypechecked 7,471 7,471 0 0.0%
Sema.NumGenericSignatureBuilders 4,646 4,646 0 0.0%
Sema.NumLazyGenericEnvironments 26,216 26,216 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 2,799 2,799 0 0.0%
Sema.NumLazyIterableDeclContexts 12,797 12,797 0 0.0%
Sema.NumTypesDeserialized 164,692 164,692 0 0.0%
Sema.NumTypesValidated 31,082 31,082 0 0.0%

@slavapestov
Copy link
Contributor Author

@swift-ci Please test Linux

@slavapestov slavapestov merged commit 28b471c into swiftlang:master Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants