[AST] NFC: ExtInfo should reserve only needed TypeBase bits #13053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both AnyFunctionType and SILFunctionType reserve 16 bits in the TypeBase for their respective "ExtInfo" bits, but then these types use less than half of the bits they reserve. This patch changes AnyFunctionType and SILFunctionType to only reserve what they need and then verify at construction time that ExtInfo bits are not being truncated. This change is motivated by the need to have more TypeBase bits available for other uses. Finally, this change fixes a copy-and-paste error introduced when AnyFunctionType and SILFunctionType stopped sharing the same ExtInfo data structure.
|
@swift-ci please test |
|
Build failed |
|
Weird. A spurious build lock failure on Linux. Let's try again: @swift-ci please test linux |
|
Build failed |
|
@swift-ci please smoke test linux |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test Linux |
|
Could we introduce constants at the top of this file for the number of bits in these ExtInfo structures? I can't think of an obvious way to static_assert that the masks fit within that number of bits, but we could at least have comments explaining the dependency. |
|
Sure. Please consider reviewing #13079. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both AnyFunctionType and SILFunctionType reserve 16 bits in the TypeBase
for their respective "ExtInfo" bits, but then these types use less than
half of the bits they reserve. This patch changes AnyFunctionType and
SILFunctionType to only reserve what they need and then verify at
construction time that ExtInfo bits are not being truncated.
This change is motivated by the need to have more TypeBase bits
available for other uses.
Finally, this change fixes a copy-and-paste error introduced when
AnyFunctionType and SILFunctionType stopped sharing the same ExtInfo
data structure.