Skip to content

[AST] NFC: Make RecursiveTypeProperties have a natural size #13054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2017
Merged

[AST] NFC: Make RecursiveTypeProperties have a natural size #13054

merged 1 commit into from
Nov 24, 2017

Conversation

davezarzycki
Copy link
Contributor

This is a minor performance optimization.

@davezarzycki
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 0116b0f

@davezarzycki
Copy link
Contributor Author

@swift-ci please test linux

DougGregor
DougGregor approved these changes Nov 23, 2017
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so local manipulation of RecursiveTypeProperties uses 32-bit integers but we still store the properties in an appropriately-sized bitfield. LGTM!

@davezarzycki davezarzycki merged commit e402c10 into swiftlang:master Nov 24, 2017
@davezarzycki davezarzycki deleted the nfc_natural_sized_RecursiveTypeProperties branch November 24, 2017 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davezarzycki @swift-ci @DougGregor