[Sema] Remove a superfluous diagnosis #1308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same diagnostic (but including the Fix-It hint) is already issued twice (!) in `applyGenericArguments`.
|
If you have a TypeRepr handy, I think you might be able to mark it as invalid and not issue the diagnostic if it is already so. |
If the TypeRepr is marked invalid, the function isn't called a second time
|
It seems I don't even have to check if it's invalid, if I mark it invalid the first time the function isn't called again in a later stage. |
slavapestov
added a commit
that referenced
this pull request
Feb 15, 2016
[Sema] Remove a superfluous diagnosis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same diagnostic (but including a Fix-It hint) is already issued twice (!) in
applyGenericArguments.