[test] More deserialization recovery vtable layout tests #13103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could have had different behavior from normal 'required', but it doesn't. Everything seems to work.
|
@slavapestov Anything else you can think of? @swift-ci Please test |
slavapestov
approved these changes
Nov 28, 2017
| @@ -144,7 +144,7 @@ open class User { | |||
| // CHECK-RECOVERY: /* placeholder for _ */ | |||
| public subscript(_: WrappedInt) -> () { return () } | |||
|
|
|||
| // CHECK: subscript<T>(_: T) -> () where T : HasAssoc, T.Assoc == WrappedInt { get } | |||
| // CHECKx: subscript<T>(_: T) -> () where T : HasAssoc, T.Assoc == WrappedInt { get } | |||
There was a problem hiding this comment.
Is CHECKx intentional?
There was a problem hiding this comment.
Bah, I hadn't rebuilt everything to pick up Nathan's fix for this. Thanks for the catch.
We already a section on this but it didn't check vtable offsets. Better to have this explicitly tested! rdar://problem/35508966
jrose-apple
force-pushed
the
getting-testy
branch
from
8937775 to
34de03d
Compare
|
@swift-ci Please smoke test and merge |
1 similar comment
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/35508966