-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Fix multi-arch cross-compiling #13108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,10 +45,19 @@ static void updateRuntimeLibraryPath(SearchPathOptions &SearchPathOpts, | |
llvm::SmallString<128> LibPath(SearchPathOpts.RuntimeResourcePath); | ||
|
||
llvm::sys::path::append(LibPath, getPlatformNameForTriple(Triple)); | ||
SearchPathOpts.RuntimeLibraryPath = LibPath.str(); | ||
if (Triple.isOSDarwin()) { | ||
// On Darwin the library search path is where we store fat binaries. | ||
SearchPathOpts.RuntimeLibraryPath = LibPath.str(); | ||
} | ||
|
||
llvm::sys::path::append(LibPath, swift::getMajorArchitectureName(Triple)); | ||
SearchPathOpts.RuntimeLibraryImportPath = LibPath.str(); | ||
if (!Triple.isOSDarwin()) { | ||
// On platforms without fat binaries, we use the arch specific | ||
// directory for searching for binaries. This is the same as the import | ||
// path for modules. | ||
SearchPathOpts.RuntimeLibraryPath = LibPath.str(); | ||
} | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not sink the LibPath calculation into the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure. I'll look at writing this be more clear with one branch instead of two. I was over optimizing trying to avoid creating two string allocs for the non-Darwin path at the sake of some clarity. Basically:
|
||
void CompilerInvocation::setRuntimeResourcePath(StringRef Path) { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -80,43 +80,34 @@ set(swift_runtime_library_compile_flags ${swift_runtime_compile_flags}) | |
list(APPEND swift_runtime_library_compile_flags -DswiftCore_EXPORTS) | ||
list(APPEND swift_runtime_library_compile_flags -I${SWIFT_SOURCE_DIR}/include) | ||
|
||
set(sdk "${SWIFT_HOST_VARIANT_SDK}") | ||
if(SWIFT_BUILD_STATIC_STDLIB AND "${sdk}" STREQUAL "LINUX") | ||
list(REMOVE_ITEM swift_runtime_sources ImageInspectionELF.cpp) | ||
if(SWIFT_BUILD_STATIC_STDLIB) | ||
set(static_binary_lnk_file_list) | ||
string(TOLOWER "${sdk}" lowercase_sdk) | ||
foreach(sdk ${SWIFT_SDKS}) | ||
if(NOT "${sdk}" STREQUAL "LINUX" AND | ||
NOT "${sdk}" STREQUAL "FREEBSD" AND | ||
NOT "${sdk}" STREQUAL "ANDROID") | ||
continue() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe only these SDKs will work with the static-executable-args.lnk file we have now. The arguments in that file are linux specific. We should in theory dynamically generate it like we do with the gen-static-stdlib script instead. |
||
endif() | ||
|
||
# These two libraries are only used with the static swiftcore | ||
add_swift_library(swiftImageInspectionShared STATIC | ||
ImageInspectionELF.cpp | ||
C_COMPILE_FLAGS ${swift_runtime_library_compile_flags} | ||
LINK_FLAGS ${swift_runtime_linker_flags}) | ||
set_target_properties(swiftImageInspectionShared PROPERTIES | ||
ARCHIVE_OUTPUT_DIRECTORY "${SWIFTSTATICLIB_DIR}/${lowercase_sdk}") | ||
|
||
# Generate the static-executable-args.lnk file used for ELF systems (eg linux) | ||
set(linkfile "${lowercase_sdk}/static-executable-args.lnk") | ||
add_custom_command_target(swift_static_binary_${sdk}_args | ||
COMMAND | ||
"${CMAKE_COMMAND}" -E copy | ||
"${SWIFT_SOURCE_DIR}/utils/static-executable-args.lnk" | ||
"${SWIFTSTATICLIB_DIR}/${linkfile}" | ||
OUTPUT | ||
"${SWIFTSTATICLIB_DIR}/${linkfile}" | ||
DEPENDS | ||
"${SWIFT_SOURCE_DIR}/utils/static-executable-args.lnk") | ||
|
||
list(APPEND static_binary_lnk_file_list ${swift_static_binary_${sdk}_args}) | ||
swift_install_in_component(stdlib | ||
FILES "${SWIFTSTATICLIB_DIR}/${linkfile}" | ||
DESTINATION "lib/swift_static/${lowercase_sdk}") | ||
string(TOLOWER "${sdk}" lowercase_sdk) | ||
# Generate the static-executable-args.lnk file used for ELF systems (eg linux) | ||
set(linkfile "${lowercase_sdk}/static-executable-args.lnk") | ||
add_custom_command_target(swift_static_binary_${sdk}_args | ||
COMMAND | ||
"${CMAKE_COMMAND}" -E copy | ||
"${SWIFT_SOURCE_DIR}/utils/static-executable-args.lnk" | ||
"${SWIFTSTATICLIB_DIR}/${linkfile}" | ||
OUTPUT | ||
"${SWIFTSTATICLIB_DIR}/${linkfile}" | ||
DEPENDS | ||
"${SWIFT_SOURCE_DIR}/utils/static-executable-args.lnk") | ||
|
||
list(APPEND static_binary_lnk_file_list ${swift_static_binary_${sdk}_args}) | ||
swift_install_in_component(stdlib | ||
FILES "${SWIFTSTATICLIB_DIR}/${linkfile}" | ||
DESTINATION "lib/swift_static/${lowercase_sdk}") | ||
endforeach() | ||
add_custom_target(static_binary_magic ALL DEPENDS ${static_binary_lnk_file_list}) | ||
|
||
add_swift_library(swiftImageInspectionShared OBJECT_LIBRARY TARGET_LIBRARY | ||
ImageInspectionELF.cpp | ||
C_COMPILE_FLAGS ${swift_runtime_library_compile_flags} | ||
LINK_FLAGS ${swift_runtime_linker_flags} | ||
INSTALL_IN_COMPONENT never_install) | ||
endif() | ||
|
||
add_swift_library(swiftRuntime OBJECT_LIBRARY TARGET_LIBRARY | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you call this
getRuntimeSharedLibraryPathWithArch
to matchgetRuntimeStaticLibraryPathWithArch
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the non "WithArch" variant above this one calls doesn't use the "Shared" prefix. I could rename everything but it seemed more invasive.