Skip to content

Revert "AST: UnboundGenericTypes are not legal SIL types" #13122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2017
Merged

Revert "AST: UnboundGenericTypes are not legal SIL types" #13122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2331148
Revert "AST: UnboundGenericTypes are not legal SIL types"
slavapestov Nov 28, 2017
b74d1b1
Add test case that causes IRGen to construct a SIL type with unbound …
slavapestov Nov 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lib/AST/Type.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,9 +433,6 @@ static bool isLegalSILType(CanType type) {
// L-values and inouts are not legal.
if (!type->isMaterializable()) return false;

// Unbound generic types are not legal.
if (type->hasUnboundGenericType()) return false;

// Function types must be lowered.
if (isa<AnyFunctionType>(type)) return false;

Expand Down
7 changes: 6 additions & 1 deletion ...IRGen/objc_generic_class_debug_info.swift → ...gInfo/objc_generic_class_debug_info.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@ import Swift
import Foundation
import objc_generics

extension GenericClass {
public extension GenericClass {
func method() {}
class func classMethod() {}
}

public func takesFunction<T : AnyObject>(fn: @escaping (GenericClass<T>) -> ()) -> (GenericClass<T>) -> () {
let copy = fn
return copy
}