[sil] Catch if we are creating ABI incompatible convert_function inst… #13135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructions when constructing the inst. I ran into this earlier today. It is a pretty annoying error to track down in SILGen since the verifier doesn't run until the full function is emitted. With this change, we get a check immediately when the value is constructed by SILBuilder making it a very easy problem to track down.
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ructions when constructing the inst.
I ran into this earlier today. It is a pretty annoying error to track down in
SILGen since the verifier doesn't run until the full function is emitted. With
this change, we get a check immediately when the value is constructed by
SILBuilder making it a very easy problem to track down.