Fix a compatibility suite regression involving the bridging peephole #13137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at AnyObject?. Also, ensure that @convention(block) functions can be erased to AnyObject, and teach SILGen how to do this with unchecked_ref_cast. Fixes a source compatibility suite regression.
|
@swift-ci Please test and merge. |
slavapestov
reviewed
Nov 29, 2017
| @@ -523,6 +523,14 @@ ManagedValue Transform::transform(ManagedValue v, | |||
| SGF.getLoweredLoadableType(outputSubstType)); | |||
| } | |||
|
|
|||
| // - block to AnyObject conversion | |||
There was a problem hiding this comment.
Can you make sure this doesn't happen on Linux, where blocks do not use Swift-compatible reference counting?
|
@swift-ci Please test OS X. |
|
Build failed |
|
Okay, that seems to be a disjoint failure. @swift-ci Please smoke test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weaken an assertion: conversions can go through Any but still end up at AnyObject?.
Also, ensure that @convention(block) functions can be erased to AnyObject, and teach SILGen how to do this with unchecked_ref_cast.
Fixes a source compatibility suite regression caused by #13078.