[sourcekitd] Be more aggresive with the semantic editor delay to avoid being throttled #13147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set a minimum delay of 10 seconds for the semantic editor instead of starting from 0/1 second. This helps prevent us from being throttled by the system if we have multiple crashes in a row, which allows us to keep syntactic requests working. rdar://18326221
These are semantic requests and should obey the delay to ensure we don't trigger too many crashes. rdar://18326221
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a minimum delay of 10 seconds for the semantic editor requests instead of starting from 0/1 second. This helps prevent us from being throttled by the system if we have multiple crashes in a row, which allows us to keep syntactic requests working. This trades off the minimum time it takes to recover e.g. code-completion after a crash in exchange for keeping our most basic functionality working.
rdar://18326221