Skip to content

Fix typo in 32-bit portion of Integers test #13162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2017
Merged

Fix typo in 32-bit portion of Integers test #13162

merged 1 commit into from
Dec 3, 2017

Conversation

paulmenage
Copy link

First comparison in the 32-bit test branch should be against UInt64.max.words, not Int64.max.words.

@jrose-apple jrose-apple requested a review from lorentey December 1, 2017 00:29
@shahmishal
Copy link
Member

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Dec 1, 2017

Build failed
Swift Test Linux Platform
Git Sha - 428d95b

@natecook1000
Copy link
Member

@swift-ci Please test Linux platform

@paulmenage
Copy link
Author

FWIW, this test is marked // REQUIRES: OS=macosx so the Linux CI is presumably going to skip it anyway.

@lorentey
Copy link
Member

lorentey commented Dec 3, 2017

LGTM

@lorentey lorentey merged commit a14664a into swiftlang:master Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorentey lorentey lorentey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paulmenage @shahmishal @swift-ci @natecook1000 @lorentey