Skip to content

[build-script] Better metavar formatting #13167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

Rostepher
Copy link
Contributor

Purpose

This PR updates the action class hierarchy in the argparse overlay module to have more default metavars and to populate the underlying argparse.Action dest attribute such that we can leverage the default metavar formatting.

@Rostepher Rostepher force-pushed the better-metavar-formatting branch from 2405f7b to 2ad5971 Compare November 30, 2017 01:46
@Rostepher
Copy link
Contributor Author

@swift-ci please smoke test

@Rostepher Rostepher force-pushed the better-metavar-formatting branch from 2ad5971 to 0f6397b Compare November 30, 2017 20:00
@Rostepher
Copy link
Contributor Author

@swift-ci please smoke test

@Rostepher Rostepher merged commit e05c2cc into swiftlang:master Nov 30, 2017
@Rostepher Rostepher deleted the better-metavar-formatting branch November 30, 2017 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant