-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[stdlib] Temporarily exclude DoubleWidth from the standard library #13182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci Please test |
@swift-ci Please smoke benchmark |
@swift-ci please smoke test compiler performance |
Build failed |
I'm pretty sure the arithmetic operators are supposed to stay transparent for both overflow analysis and debug info. I'm not sure why you'd see a difference between |
Build failed |
@jrose-apple early inlining, more convoluted code, less optimization? I don't honestly know. But evidence is that it helps. As for the overflow diagnostics, there are tests that should show if we regress. |
IIRC some of the overflow diagnostic tests were already broken by other work you all did last year; have those been restored yet? If removing |
Build comment file:Optimized (O)Regression (25)
Improvement (28)
No Changes (281)
Unoptimized (Onone)Regression (38)
Improvement (23)
No Changes (273)
Hardware Overview
|
Looks like only one debug info test failed; we should probably have more. You really can't remove |
The problem is not with transparent per se. It’s saving some space in the implementation of `DoubleWidth`. But it’s not enough. So I’ll just leave it as is, until we have a better solution.
And no, those overflow diagnostics tests have not been fixed, and I am very aware of that =(
… On Nov 30, 2017, at 3:14 PM, Joe Groff ***@***.***> wrote:
IIRC some of the overflow diagnostic tests were already broken by other work you all did last year; have those been restored yet?
If removing @_transparent really saves a significant amount of binary size, can we make transparent things always-emit-into-client? The symbols ought to be rarely needed in practice since they'll almost always be inlined.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#13182 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD6C0g2p3RozZ_tpPxys06BswzUML-uks5s7zbtgaJpZM4QxQUj>.
|
@swift-ci Please smoke test |
<rdar://problem/32726173>
@swift-ci Please test and merge |
1 similar comment
@swift-ci Please test and merge |
No description provided.