libSyntax: support declaration modifiers, like static, private, etc. #13221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some declaration modifiers may have more details attached, like "private(set)". This patch represents the detail part "(set)" as a token list. Also, this patch fixes an issue where back tracking scope doesn't recover leading/trailing trivia information.
|
@swift-ci please smoke test |
|
@rintaro could you review this please? especially the part of recovering trivia information. |
|
Could you hold this? This workaround shouldn't be needed if we correctly restore the Lexer state when backtracking. The problem is mismatch between start position of LeadingTrivia and |
|
Sure, thank you for looking into this! @rintaro |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci Please clean test Linux platform |
|
Build failed |
|
@swift-ci Please clean test Linux platform |
davidungar
pushed a commit
to davidungar/swift
that referenced
this pull request
Dec 5, 2017
…wiftlang#13221) Some declaration modifiers may have more details attached, like "private(set)". This patch represents the detail part "(set)" as a token list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some declaration modifiers may have more details attached, like
"private(set)". This patch represents the detail part "(set)" as a token
list.
Also, this patch fixes an issue where back tracking scope doesn't
recover leading/trailing trivia information.