Preparatory, simple changes to ease reviewing of the next PR. #13233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change “have” routines to “has”. Use more consistent casing. Remove spurious “DelayedFunctionParsing” option. Move debugFail routines to top lexical level. Rename and reorder declaration of functions in FrontendArgsToOptionsConverter. Move, reword, and doxygenate comments for some of those functions. Fix casing on some more setUp* functions. Return NoneAction instead of existing RequestedAction in FrontendArgsToOptionsConverter::determineRequestedAction. Remove test names and put in FIXME’s. Remove “Jordan” from comments & reword. Reorder if-then arms of FrontendArgsToOptionsConverter::computeOutputFilenames for readability. Test for empty string instead of equality with “”. Use hasUnusedModuleDocOutputPath. Remove optionality from return type of getOutputFilenamesFromCommandLineOrFilelist. Rename isPrimaryInputAFileAt to isThereAPrimaryInputWithAFilenameAt. Added a FIXME in doesActionProduceOutput to reflect that some actions actually do not produce output.
Rename isThereAPrimaryInputWithAFilenameAt to isInputPrimary. Remove spurious delayed_function_body_parsing. Simply return type of getOutputFilenamesFromCommandLineOrFilelist.
Unify actionHasOutput w/ doesActionProduceOutput & correct both. Do not set an output filename if there is no output. Add test to ensure no output is created in immediate mode. Restore NFC module name computation.
|
@swift-ci please test |
- Moved getOutputFilenamesFromCommandLineOrFilelist & readOutputFileLIst to better places in the file. - Capitalization changes. - Make actionIsImmediate static. - Add braces around sections of CompilerInstance::setup to clarify scopes of local variables.
|
@swift-ci please test |
|
Build failed |
|
Build failed |
jrose-apple
approved these changes
Dec 4, 2017
|
@swift-ci please clean test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR isolates the trivial changes that are included in the next PR, in order to ease review by splitting off some of the work.