Skip to content

Remove tee to temporary directory #13239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2017

Conversation

parkera
Copy link
Contributor

@parkera parkera commented Dec 4, 2017

It looks like this tee was some kind of temporary debugging thing, and it's failing the test on my Linux build because my user doesn't happen to have access to /tmp/xxx.

@parkera parkera requested a review from slavapestov December 4, 2017 01:11
@parkera
Copy link
Contributor Author

parkera commented Dec 4, 2017

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Dec 4, 2017

Build failed
Swift Test OS X Platform
Git Sha - 10984bf

@compnerd
Copy link
Member

compnerd commented Dec 4, 2017

@swift-ci please test macOS platform

@compnerd
Copy link
Member

compnerd commented Dec 4, 2017

@parkera not sure if my review is good enough, but LGTM

@jrose-apple
Copy link
Contributor

I think you can go ahead on this if Slava doesn't get back to you. It's clearly not going to break the test, and if he still needs it for testing he can add it back (hopefully in a more principled way).

@parkera parkera merged commit 89102b7 into swiftlang:master Dec 5, 2017
@parkera
Copy link
Contributor Author

parkera commented Dec 5, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants