[SE-0143] Eliminate assertions blocking the use of conditional conformances #13253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mances. Early on in the development of conditional conformances, we put in a bunch of assertions for code that uses `conformsToProtocol()` but wasn't handling conditional conformances. Now, `conformsToProtocol()` handles conditional conformances by default, and these assertions are tripping up code that would work. Remove the assertions and add test cases that used to trip up the assertions (but now work).
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test Linux |
1 similar comment
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early on in the development of conditional conformances, we put in a bunch
of assertions for code that uses
conformsToProtocol()but wasn't handlingconditional conformances. Now,
conformsToProtocol()handles conditionalconformances by default, and these assertions are tripping up code
that would work.
Remove the assertions and add test cases that used to trip up the
assertions (but now work).