Fixes an invalid assert in No Payload Enum's collectArchetypeMetadata: the type itself might contain an Archetype. We need to check that it is not an Archetype itself #13257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test and merge |
slavapestov
reviewed
Dec 4, 2017
lib/IRGen/GenEnum.cpp
Outdated
| @@ -945,7 +945,7 @@ namespace { | |||
| llvm::MapVector<CanType, llvm::Value *> &typeToMetadataVec, | |||
| SILType T) const override { | |||
| auto canType = T.getSwiftRValueType(); | |||
| assert(!canType->hasArchetype() && | |||
| assert(!canType->getWithoutSpecifierType()->is<ArchetypeType>() && | |||
There was a problem hiding this comment.
Do you have an example where getWithoutSpecifierType() is not a no-op?
…: the type itself might contain an Archetype. We need to check that it is not an Archetype itself
shajrawi
force-pushed
the
fix_outline_assert
branch
from
b890e3e to
5be50d7
Compare
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
radar rdar://problem/35831517