[stdlib] Replace various uses of BlahSlice with Slice to reduce warnings #13263
Conversation
|
@swift-ci please test |
| @@ -701,10 +701,10 @@ public struct ${Self}<T> : ${SelfProtocols} { | |||
| % end | |||
| } | |||
|
|
|||
| public subscript(bounds: Range<${Index}>) -> ${SelfSlice}<${Self}<T>> { | |||
| public subscript(bounds: Range<${Index}>) -> Slice<${Self}<T>> { | |||
There was a problem hiding this comment.
You can remove the definition of SelfSlice too right?
There was a problem hiding this comment.
It's still used within the gyb. These tests create Minimal${SelfSlice} opaque types for some tests.
I did miss some more ${SelfSlice} uses tho.
There was a problem hiding this comment.
No wait that is a different test. These ones just reuse SelfSlice to create MinimalCollection names. But still, they need something like it.
There was a problem hiding this comment.
I felt guilty after this so have fixed it properly now...
airspeedswift
force-pushed
the
slice-warnings
branch
from
bbdfc9b to
4e08298
Compare
|
@swift-ci please test |
|
Build failed |
|
gah there are tests inside |
airspeedswift
force-pushed
the
slice-warnings
branch
from
4e08298 to
5a910f4
Compare
|
@swift-ci please test |
|
Build failed |
|
I'll make the matching changes in corelibs once this one lands safely. |
|
the Foundation changes look good to me. |
|
@swift-ci please test macOS platform |
|
Build failed |
|
@swift-ci please test macOS platform |
Now that
Sliceis conditionally conforming to protocols based on its base, various uses of specific slices can be replaced, suppressing deprecation warnings.Note, the validation tests generated by
validation-test/stdlib/Slice/Inputs/Template.swift.gybare still using the old slice types. That needs a bit more work to fix.