[sil] When checking for ABI compatibility of a convert_function, don'… #13283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test and merge |
1 similar comment
|
@swift-ci smoke test and merge |
shajrawi
pushed a commit
to shajrawi/swift
that referenced
this pull request
Dec 6, 2017
SIL is not in a consistent state during the lowering pass. We just make sure it is correct at the end of the pass. This broke PR swiftlang#13283 (verifying convert_function instructions in the builder) To workaround this issue we will be running the builder’s verifier when the SIL stage != SILStage::Lowered The SIL stage is set to lowered at the end of the module pass. This means that if this is the first lowering pass said workaround would not work. This commit sets the SIL stage to lowered at the beginning of the module pass instead
|
Oops... forgot about this (was cleaning up my remotes). |
…are the operand against itself, compare the operand against the convert_function result. This was a thinko on my part. rdar://34222540
gottesmm
force-pushed
the
pr-afcd8409db0425081e5cd81862b0f530457bfd4f
branch
from
a2b3a0c to
e9ef817
Compare
|
@swift-ci test |
|
@swift-ci source compatibility |
|
@swift-ci Please Test Source Compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t compare the operand against itself, compare the operand against the convert_function result.
This was a thinko on my part.
rdar://34222540