Don't pass -Werror to ClangImporter's clang when Swift is used from LLDB #13293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
jrose-apple
reviewed
Dec 6, 2017
| // directory and the source directory. | ||
| if (!importerOpts.DebuggerSupport) | ||
| invocationArgStrs.push_back( | ||
| "-Werror=non-modular-include-in-framework-module"); |
There was a problem hiding this comment.
Don't worry about keeping these in the same order. It's okay to put this after the fixed set of normal arguments.
There was a problem hiding this comment.
I thought there was value in grouping all module-related options together.
There was a problem hiding this comment.
Hm, okay, but then I'd rather move the whole section below the completely unconditional and uncategorized settings.
…ithin LLDB. This works a around search path problems caused by a module existing in both the build/install directory and the source directory. <rdar://problem/35714074>
adrian-prantl
force-pushed
the
35714074
branch
from
d2ba89f to
97f9e4e
Compare
|
@swift-ci smoke test and merge |
1 similar comment
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't pass -Werror to ClangImporter's clang when Swift is used from within LLDB.
This works a around search path problems caused by a module existing
in both the build/install directory and the source directory.
rdar://problem/35714074