Skip to content

Set SIL stage to lowered at the *start* of address lowering #13294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2017
Merged

Set SIL stage to lowered at the *start* of address lowering #13294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions lib/IRGen/LoadableByAddress.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2499,11 +2499,14 @@ void LoadableByAddress::updateLoweredTypes(SILFunction *F) {

/// The entry point to this function transformation.
void LoadableByAddress::run() {
// Set the SIL state before the PassManager has a chance to run
// verification.
getModule()->setStage(SILStage::Lowered);

for (auto &F : *getModule())
runOnFunction(&F);

if (modFuncs.empty()) {
getModule()->setStage(SILStage::Lowered);
return;
}

Expand Down Expand Up @@ -2643,10 +2646,6 @@ void LoadableByAddress::run() {
// Fix all instructions that rely on block storage type
fixStoreToBlockStorageInstrs();

// Set the SIL state before the PassManager has a chance to run
// verification.
getModule()->setStage(SILStage::Lowered);

// Clean up the data structs:
modFuncs.clear();
conversionInstrs.clear();
Expand Down