Don't pass -Werror to ClangImporter's clang when Swift is used from LLDB

[adrian-prantl]

Don't pass -Werror to ClangImporter's clang when Swift is used from within LLDB.

This works a around search path problems caused by a module existing
in both the build/install directory and the source directory.

rdar://problem/35714074

(cherry picked from commit 97f9e4e)

[adrian-prantl]

@swift-ci please nominate:

Explanation: This works a around search path problems caused by a module existing in both the build/install directory and the source directory.
Scope: Avoid -Werror in ClangImporter
Radar: rdar://problem/35714074
Risk: Low.
Testing: Regression test in swift.

[adrian-prantl]

@swift-ci test

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - f23c289

[adrian-prantl]

@shahmishal
ninja: error: '/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-4.1-branch/buildbot_linux/swift-linux-x86_64/lib/swift/linux/x86_64/swift_begin.o', needed by '../buildbot_linux/foundation-linux-x86_64/Foundation/libFoundation.so', missing and no known rule to make it

[shahmishal]

@graydon is looking into this issue, we started seeing it after we re-branched swift-4.1-branch from master

[adrian-prantl]

@swift-ci test linux platform

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - f23c289

[shahmishal]

swiftlang/swift-corelibs-foundation#1356

@swift-ci test Linux

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - f23c289

[shahmishal]

New issue:

Foundation/NSError.swift:285:16: error: use of unresolved identifier '_swift_getDefaultErrorCode'
        return _swift_getDefaultErrorCode(self)
               ^~~~~~~~~~~~~~~~~~~~~~~~~~
Swift._getDefaultErrorCode:3:13: note: did you mean '_getDefaultErrorCode'?

[shahmishal]

Also, need to revert swiftlang/swift-corelibs-foundation#1322

[shahmishal]

swiftlang/swift-corelibs-foundation#1357

@swift-ci test Linux

[adrian-prantl]

@swift-ci merge

[adrian-prantl]

Who has the permission to merge this?

[adrian-prantl]

@bob-wilson Do you have the permission to merge this?

[jrose-apple]

There is no "swift-ci merge". If you've gotten approval to merge this (from the nomination), you can just click the button.

[adrian-prantl]

Apparently not:

You're not authorized to merge this pull request.

The button is dimmed for me.

[adrian-prantl]

I also couldn't find the place in the github UI where I could look up who is authorized...

[adrian-prantl]

Weird, it also says:

This pull request can be automatically merged by project collaborators Only those with write access to this repository can merge pull requests.

I would have expected to be in that group.

[shahmishal]

@adrian-prantl swift-4.1-branch is under CCC.

[adrian-prantl]

@shahmishal so who has the permission to merge branches under CCC?

[shahmishal]

@tkremenek should be able to approve this PR.

Info from Swift 4.1 Release Process blog:

https://swift.org/blog/swift-4-1-release-process/

All change going into the swift-4.1-branch (outside changes being merged in automatically from master) must go through pull requests that are accepted by the corresponding release manager.

Release Managers
The overall management of the release will be overseen by the following individuals, who will announce when stricter control of change goes into effect for the Swift 4 release as the release converges:

Ted Kremenek is the overall release manager for Swift 4.1.

Frédéric Riss is the release manager for swift-llvm, swift-clang, and swift-compiler-rt.

Ben Cohen is the release manager for the Swift Standard Library.

Tony Parker is the release manager for swift-corelibs-foundation.

Daniel Steffen is the release manager for swift-corelibs-libdispatch.

Brian Croom is the release manager for swift-corelibs-xctest.

Rick Ballard is the release manager for swift-package-manager.

Daniel Dunbar is the release manager for swift-llbuild.

Please feel free to email swift-dev or Ted Kremenek directly concerning any questions about the release management process.

[adrian-prantl]

@tkremenek Could you please merge this?

[shahmishal]

@swift-ci please nominate

[adrian-prantl]

@shahmishal (I'm trying to understand the process better.) This PR is already approved. Why did you nominate it again?

[shahmishal]

Sorry, I wrote it on the wrong PR.