Skip to content

[overlay][gardening] Use NSRange.init over NSMakeRange #13316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2017
Merged

[overlay][gardening] Use NSRange.init over NSMakeRange #13316

merged 1 commit into from
Dec 8, 2017

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Dec 7, 2017

No description provided.

@ikesyo
Copy link
Member Author

ikesyo commented Dec 7, 2017

@swift-ci Please smoke test

phausler
phausler approved these changes Dec 7, 2017
View reviewed changes
Copy link
Contributor

@phausler phausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look isomorphic to me.

@phausler
Copy link
Contributor

phausler commented Dec 7, 2017

@swift-ci please test and merge

@ikesyo
Copy link
Member Author

ikesyo commented Dec 7, 2017

@swift-ci test and merge

@swift-ci swift-ci merged commit f767040 into swiftlang:master Dec 8, 2017
@ikesyo ikesyo deleted the nsrange-init branch December 8, 2017 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phausler phausler phausler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikesyo @phausler @swift-ci