Skip to content

[libSyntax] Support TypeExpr #13317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2017
Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Dec 7, 2017

For now, it's just for Any at expression position.

CC: @nkcsgexi

@rintaro
Copy link
Member Author

rintaro commented Dec 7, 2017

@swift-ci Please smoke test

@rintaro
Copy link
Member Author

rintaro commented Dec 7, 2017

@swift-ci Please smoke test OS X platform

@harlanhaskins
Copy link
Contributor

This raises an interesting question -- we perform folding of Array and Dictionary types from ArrayExpr to ArrayTypeRepr during type-checking. Still not sure if/how we want to represent that at libSyntax time...

Just for `Any` for now.
@rintaro
Copy link
Member Author

rintaro commented Dec 7, 2017

@swift-ci Please smoke test

@rintaro
Copy link
Member Author

rintaro commented Dec 7, 2017

Yeah, I'm not sure as well 😓

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nkcsgexi nkcsgexi merged commit 8bbe4d2 into swiftlang:master Dec 7, 2017
@rintaro rintaro deleted the syntax-typexpr branch January 23, 2018 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants