Skip to content

[4.1] [PrintAsObjC] Reintroduce +new when reintroducing -init #13331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2017
Merged

[4.1] [PrintAsObjC] Reintroduce +new when reintroducing -init #13331

merged 1 commit into from
Dec 11, 2017

Conversation

jrose-apple
Copy link
Contributor

@jrose-apple jrose-apple commented Dec 7, 2017 •
edited
Loading

  • Explanation: An unavailable -init makes +new unavailable, but reintroducing it in a subclass should reintroduce +new if the root class is NSObject (where +new is implemented).
  • Scope: Only affects classes that implement a non-overriding init() exposed to Objective-C
  • Issue: rdar://problem/35914080 rdar://problem/35941258
  • Reviewed by: @DougGregor, @JaviSoto
  • Risk: Low. Only affects ObjC printing, not any run-time behavior.
  • Testing: Added compiler regression tests.

@jrose-apple
[PrintAsObjC] Reintroduce +new when reintroducing -init. (swiftlang#1…
7c789dc 
…3320)

Follow-up to 49c65fa to account for subclasses. An unavailable
-init makes +new unavailable, but reintroducing it in a subclass
should reintroduce +new if the root class is NSObject (where +new is
implemented).

rdar://problem/35914080
(cherry picked from commit 2bc0106)
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@jrose-apple
Copy link
Contributor Author

Ewa, can you mark this as approved so it can be merged? (And then feel free to merge rather than wait for me to notice.)

@ematejska ematejska merged commit 54e3200 into swiftlang:swift-4.1-branch Dec 11, 2017
@jrose-apple jrose-apple deleted the 4.1-new-and-improved branch December 11, 2017 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees

@ematejska ematejska

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrose-apple @ematejska