[Syntax] Fix roundtrip test #13339
Merged
[Syntax] Fix roundtrip test #13339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
With the caveat that it's been a long time since I introduced that so I'm likely lacking a lot of context, I can't think of a reason. |
instead of PersistentParserState::ParserPos.
rintaro
force-pushed
the
syntax-parserposition
branch
from
9e4a08f to
5cd6a0b
Compare
Instead of re-lexing Trivias. Trivia might contain skipped garbage which might be re-lexed as tokens.
was always success because of logic error in the script.
rintaro
force-pushed
the
syntax-parserposition
branch
from
5cd6a0b to
1615a67
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Lexerstate hadn't been correctly restored beyond multipleparseIntoSourceFile()invocation. It used to result trivia loss betweenTopLevelCodeDecl.This PR fixes that by holding exact
ParserPosition(renamed fromParser::ParserPosition) inPersistentParserState.Also,
utils/round-trip-syntax-testused to always report "SUCCESS" because of a logic error in the script.