Skip to content

[swift-4.1-branch][stdlib] Utilize conditional conformances for lazy collections #13349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 9, 2017
Merged

[swift-4.1-branch][stdlib] Utilize conditional conformances for lazy collections #13349

merged 7 commits into from
Dec 9, 2017

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Dec 8, 2017 •
edited
Loading

  • Explanation: Utilize conditional conformances to simplify
    LazyFilter/LazyMap/Lazy Collection hierarchies.
  • Scope of Issue: Reduces the API surface (fewer types) of the standard
    library, which results in simpler user code.
  • Risk: Minimal
  • Reviewed By: Ben Cohen
  • Testing: Existing automated test suite
  • Directions for QA: N/A
  • Radar: rdar://problem/35944334

@moiseev moiseev requested a review from airspeedswift December 8, 2017 22:50
@moiseev
Copy link
Contributor Author

moiseev commented Dec 8, 2017

@swift-ci Please test

@moiseev
Copy link
Contributor Author

moiseev commented Dec 8, 2017

@swift-ci Please nominate

@swift-ci
Copy link
Contributor

swift-ci commented Dec 8, 2017

Build failed
Swift Test OS X Platform
Git Sha - 52c91b15a374ff31fc1be6582e0ee7b9e685d2d1

@swift-ci
Copy link
Contributor

swift-ci commented Dec 8, 2017

Build failed
Swift Test Linux Platform
Git Sha - 52c91b15a374ff31fc1be6582e0ee7b9e685d2d1

Max Moiseev added 7 commits December 8, 2017 16:35
@moiseev moiseev force-pushed the conditional-collections-4 branch from 52c91b1 to 984c3bf Compare December 9, 2017 00:38
@moiseev
Copy link
Contributor Author

moiseev commented Dec 9, 2017

@swift-ci Please test

@swiftlang swiftlang deleted a comment from swift-ci Dec 9, 2017
@swiftlang swiftlang deleted a comment from swift-ci Dec 9, 2017
@airspeedswift airspeedswift merged commit 4c99be4 into swiftlang:swift-4.1-branch Dec 9, 2017
@graydon
Copy link
Contributor

graydon commented Dec 10, 2017

Sorry but this seems to have broken CI bots again (see rdar://35902381), need to back it out.

graydon added a commit that referenced this pull request Dec 10, 2017
@graydon
Revert "[swift-4.1-branch][stdlib] Utilize conditional conformances f…
d54b6bc 
…or lazy collections (#13349)"

This reverts commit 4c99be4.
@graydon graydon mentioned this pull request Dec 10, 2017
Merged
@moiseev moiseev mentioned this pull request Dec 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airspeedswift airspeedswift airspeedswift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moiseev @swift-ci @graydon @airspeedswift