CopyForwarding - small redesign to fix bugs. #13356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy forwarding was designed with some assumptions about symmetry of operations. If copy_value/destroy_value are expanded somewhere for a given value, then they should be expanded everywhere. The pass took a conservative approach to SIL patterns that were guaranteed safe, and bailed out on unknown patterns. However, due to some over-aggressive code factoring, the assumption wasn't being checked in one corner case. This redesign makes a clear distinction between the requirements for forward vs. backward propagation. Fixes <rdar://35646292> Swift CI: resilience bot seg faults in stdlib/RangeReplaceable.swift.gyb
|
@swift-ci test. |
|
Thanks for fixing this! Don't forget you need to un-XFAIL the actual failing test though. |
|
@swift-ci test and merge. |
1 similar comment
|
@swift-ci test and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy forwarding was designed with some assumptions about symmetry of
operations. If copy_value/destroy_value are expanded somewhere for a given
value, then they should be expanded everywhere. The pass took a conservative
approach to SIL patterns that were guaranteed safe and bailed out on unknown
patterns. However, due to some over-aggressive code factoring, the assumption
wasn't being checked in one corner case.
This redesign makes a clear distinction between the requirements for forward
vs. backward propagation.
Fixes rdar://35646292 Swift CI: resilience bot seg faults in
stdlib/RangeReplaceable.swift.gyb