Skip to content

[4.1] In Swift 3/4 mode, continue treating 'lazy override' as an override #13375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2017
Merged

[4.1] In Swift 3/4 mode, continue treating 'lazy override' as an override #13375

merged 1 commit into from
Dec 12, 2017

Conversation

jrose-apple
Copy link
Contributor

  • Explanation: Follow-up for [4.1] For 'lazy', make "cannot override with a stored property" a warning #13308. Without this, the declaration would be accepted, but any uses of the overridden property would be treated as ambiguous because the property wouldn't really be marked as an override.
  • Scope: All type-checker-synthesized accessors, to try to head off similar problems in the future.
  • Issue: rdar://problem/35900345
  • Reviewed by: @slavapestov
  • Risk: Medium-low. There's not much new code here, but what was there before has been moved around.
  • Testing: Added more compiler regression tests under Swift 4 mode.

@jrose-apple
In Swift 3/4 mode, continue treating 'lazy override' as an override (s…
642b463 
…wiftlang#13335)

Follow-up for 7c707ce. Without this, the declaration would be
accepted, but any uses of the overridden property would be treated as
ambiguous because the property wouldn't really be marked as an
override.

rdar://problem/35900345
(cherry picked from commit ca9d5a9)
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@jrose-apple jrose-apple merged commit dc50ec3 into swiftlang:swift-4.1-branch Dec 12, 2017
@jrose-apple jrose-apple deleted the 4.1-lazy-override-less-ambiguity branch December 12, 2017 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrose-apple @slavapestov