[Conformance checking] More refactoring of associated type inference. #13378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the rest of associated type inference into the new source file, and split RequirementEnvironment into its own AST-level header, because it can be re-used and has no ties to the type checker.
|
@swift-ci please smoke test and merge |
slavapestov
reviewed
Dec 12, 2017
| @@ -0,0 +1,124 @@ | |||
| //===--- RequirementEnvironment.h - Swift Language Type ASTs ----*- C++ -*-===// | |||
There was a problem hiding this comment.
Wrong description here
slavapestov
reviewed
Dec 12, 2017
| @@ -0,0 +1,231 @@ | |||
| //===--- RequirementEnvironment.cpp - ASTContext Implementation -----------===// | |||
There was a problem hiding this comment.
Also wrong description here
There was a problem hiding this comment.
(FWIW, I fixed these in a subsequent, completely-unrelated PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the rest of associated type inference into the new source file,
and split RequirementEnvironment into its own AST-level header, because it
can be re-used and has no ties to the type checker.