[arc] Make all *RefCountStates and RCStateTransition trivially destru… #1338
+49
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test OS X platform |
|
@swift-ci Please test Linux Platform |
|
The Swift Test OS X Platform failed b/c I asked Mishal to kill it. I just wanted a smoke test on linux/OSX. |
|
@swift-ci Please test Linux Platform |
gottesmm
force-pushed
the
arc-make-trivial
branch
from
0e03ff7 to
f34adb2
Compare
|
@swift-ci Please test Linux Platform |
|
@swift-ci Please smoke test OS X platform |
| // These static assert checks are here for performance reasons. | ||
| static_assert(IsTriviallyCopyable<RCStateTransition>::value, | ||
| "RCStateTransitions must be trivially copyable"); | ||
| static_assert(IsTriviallyDestructible<RCStateTransition>::value, |
There was a problem hiding this comment.
IsTriviallyCopyable implies IsTriviallyDestructible. [citation]
There was a problem hiding this comment.
Touche. I did get a little trigger happy.
…ctable and constructable. Tested via static assert. There is no reason for these data structures to not have these properties. Adding these properties will improve the compile time efficiency of ARC by allowing for cheaper copying and 0 cost destruction.
gottesmm
force-pushed
the
arc-make-trivial
branch
from
f34adb2 to
d55ebae
Compare
|
OS X smoke test is taking too long. The linux test passed. On my machine, the mac os x tests pass. |
gottesmm
added a commit
that referenced
this pull request
Feb 18, 2016
[arc] Make all *RefCountStates and RCStateTransition trivially destru…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ctable and constructable.
Tested via static assert.
There is no reason for these data structures to not have these properties.
Adding these properties will improve the compile time efficiency of ARC by
allowing for cheaper copying and 0 cost destruction.