Suggest @objc for overrides of declarations from/in extensions. #13417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Swift class model does not support overriding declarations where either the overridden declaration or the overriding declaration are in an extension. However, the Objective-C class model does, so marking the declaration as @objc (when possible) will work around the limitation. Customize the "cannot override declaration in extension" diagnostic to suggest adding @objc to the overridden declaration in cases where @objc is permitted. Fixes SR-6512 / rdar://problem/35787914.
|
@swift-ci please smoke test and merge |
NachoSoto
reviewed
Dec 13, 2017
| @@ -67,7 +67,7 @@ class A { | |||
| set { } | |||
| } | |||
|
|
|||
| func overriddenInExtension() {} // expected-note {{overridden declaration is here}} | |||
| func overriddenInExtension() {} // expected-note {{overri}} | |||
| class func ef2() {} // expected-note {{overri}} | ||
| class func ef3() {} // expected-note {{overri}} | ||
| class func ef4() {} // expected-note {{overri}} | ||
| class func ef5() {} // expected-note {{overri}} |
There was a problem hiding this comment.
Or is this a magic string somehow?
There was a problem hiding this comment.
If the rest of the diagnostic text is ancillary, you can match on a known prefix with the verifier.
There was a problem hiding this comment.
It's a string that's common to both the "we have Objective-C interop" and "we don't have Objective-C interop" cases. If I tried to match the whole thing, the tests would fail on either Linux or Darwin, because the produce different diagnostics depending on whether that particular declaration could be made @objc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Swift class model does not support overriding declarations where either
the overridden declaration or the overriding declaration are in an extension.
However, the Objective-C class model does, so marking the declaration as
@objc (when possible) will work around the limitation.
Customize the "cannot override declaration in extension" diagnostic to
suggest adding @objc to the overridden declaration in cases where
@objc is permitted. Fixes SR-6512 / rdar://problem/35787914.