Serialization: Fix crash when deserializing store_unowned SIL instruction #13418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll pointer dereferences into assertions
…tion We were casting the operand type to a WeakStorageType when in fact it is an UnownedStorageType. Fixes <rdar://problem/35980211>.
|
@swift-ci Please smoke test |
|
Wow. How did this ever work for plain class references? Thanks for the quick turnaround. |
|
@jrose-apple It looks like existentials and Objective-C classes use one access pattern involving a store_unowned, and Swift-native classes use another where we do a ref_to_unowned followed by a plain store. @rjmccall would know the details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/35980211.