[4.1] [GSB] Canonicalize conformance access paths on-the-fly. #13428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
DougGregor
commented
Dec 14, 2017
DougGregor
commented
- Explanation: Eliminates a crash during IRGen when dealing with redundant associated type conformances in certain multi-file scenarios and with some declaration ordering.
- Scope of Issue: Only affects cases where associated types are given redundant conformance requirements in a protocol, and only under certain perturbations of the source. Affected some versions of the Vapor project.
- Risk: Low; it's a proper fix for a previously-broken code path.
- Reviewed By: @slavapestov
- Testing: Existing automated test suite, new tests, source compatibility suite
- Directions for QA: N/A
- SR / Radar: SR-6200 / rdar://problem/35113583
|
@swift-ci please test |
|
Ugh, gotta rebase |
When forming a conformance access path, remove from consideration any requirement sources that contain protocol requirements that aren't found in the requirement signature. This ensure well-formedness of the resulting conformance access path. Huge thanks to Slava for reducing this one, and apologies to Arnold for having to track it down a second time before I fixed it. Fixes SR-6200 / rdar://problem/35113583. (cherry picked from commit a77dec1)
If we used the requirement signature to create a protocol requirement element in a requirement source, there's no need to verify that it's from the requirement signature (duh). (cherry picked from commit e10ecbd)
DougGregor
force-pushed
the
canonicalize-conformance-access-path-4.1
branch
from
08b8859 to
9b2c185
Compare
|
@swift-ci please test |
|
@swift-ci please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.