Skip to content

[Syntax] Use SyntaxKind APIs for getUnknownKind() #13429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions include/swift/Syntax/SyntaxFactory.h.gyb
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@ struct SyntaxFactory {
/// between these two numbers is the number of optional children.
static std::pair<unsigned, unsigned> countChildren(SyntaxKind Kind);

static SyntaxKind getUnknownKind(SyntaxKind Kind);

static Syntax
makeBlankCollectionSyntax(SyntaxKind Kind);

Expand Down
2 changes: 2 additions & 0 deletions include/swift/Syntax/SyntaxKind.h.gyb
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ bool isPatternKind(SyntaxKind Kind);
bool isTokenKind(SyntaxKind Kind);

bool isUnknownKind(SyntaxKind Kind);

SyntaxKind getUnknownKind(SyntaxKind Kind);
} // end namespace syntax

namespace json {
Expand Down
26 changes: 0 additions & 26 deletions lib/Syntax/SyntaxFactory.cpp.gyb
Original file line number Diff line number Diff line change
Expand Up @@ -203,32 +203,6 @@ SyntaxFactory::createSyntax(SyntaxKind Kind, llvm::ArrayRef<Syntax> Elements) {
}
}

SyntaxKind
SyntaxFactory::getUnknownKind(SyntaxKind Kind) {
switch(Kind) {
% for node in SYNTAX_NODES:
% if node.syntax_kind.endswith('Expr'):
% Result = 'SyntaxKind::UnknownExpr'
% elif node.syntax_kind.endswith('Stmt'):
% Result = 'SyntaxKind::UnknownStmt'
% elif node.syntax_kind.endswith('Decl'):
% Result = 'SyntaxKind::UnknownDecl'
% elif node.syntax_kind.endswith('Token'):
% Result = 'SyntaxKind::UnknownToken'
% elif node.syntax_kind.endswith('Type'):
% Result = 'SyntaxKind::UnknownType'
% elif node.syntax_kind.endswith('Pattern'):
% Result = 'SyntaxKind::UnknownPattern'
% else:
% Result = 'SyntaxKind::Unknown'
% end
case SyntaxKind::${node.syntax_kind}: return ${Result};
% end
default:
return SyntaxKind::Unknown;
}
}

% for node in SYNTAX_NODES:
% if node.children:
% child_params = []
Expand Down
14 changes: 14 additions & 0 deletions lib/Syntax/SyntaxKind.cpp.gyb
Original file line number Diff line number Diff line change
Expand Up @@ -84,5 +84,19 @@ bool isUnknownKind(SyntaxKind Kind) {
Kind == SyntaxKind::UnknownType ||
Kind == SyntaxKind::UnknownPattern;
}

SyntaxKind getUnknownKind(SyntaxKind Kind) {
if (isExprKind(Kind))
return SyntaxKind::UnknownExpr;
if (isStmtKind(Kind))
return SyntaxKind::UnknownStmt;
if (isDeclKind(Kind))
return SyntaxKind::UnknownDecl;
if (isTypeKind(Kind))
return SyntaxKind::UnknownType;
if (isPatternKind(Kind))
return SyntaxKind::UnknownPattern;
return SyntaxKind::Unknown;
}
} // end namespace syntax
} // end namespace swift
2 changes: 1 addition & 1 deletion lib/Syntax/SyntaxParsingContext.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ static RC<RawSyntax> createSyntaxAs(SyntaxKind Kind,
return Node->getRaw();

// Fallback to unknown syntax for the category.
return makeUnknownSyntax(SyntaxFactory::getUnknownKind(Kind), Parts);
return makeUnknownSyntax(getUnknownKind(Kind), Parts);
}

} // End of anonymous namespace
Expand Down