Skip to content

Context descriptors #13468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2018
Merged

Conversation

jckarter
Copy link
Contributor

Replacing today's nominal type descriptors with a hierarchy of context descriptors, with more efficient encoding of name information and more precise description of generic contexts.

swift-dev discussion: https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20171113/005971.html

@jckarter jckarter force-pushed the generic-requirement-details branch 8 times, most recently from f94472d to d17b941 Compare January 9, 2018 18:26
@jckarter jckarter force-pushed the generic-requirement-details branch from d17b941 to ed0c8d2 Compare January 13, 2018 02:29
@jckarter jckarter force-pushed the generic-requirement-details branch 4 times, most recently from 09e5fed to 0331642 Compare January 22, 2018 18:52
@jckarter jckarter force-pushed the generic-requirement-details branch 6 times, most recently from 96cb01b to a73a272 Compare January 28, 2018 02:01
@jckarter jckarter changed the title [WIP] Context descriptors Context descriptors Jan 28, 2018
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a73a272d9d3d3291e46483d9425b849095408612

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a73a272d9d3d3291e46483d9425b849095408612

@jckarter jckarter force-pushed the generic-requirement-details branch from a73a272 to d9cec88 Compare January 29, 2018 01:32
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swiftlang swiftlang deleted a comment from swift-ci Jan 29, 2018
@swiftlang swiftlang deleted a comment from swift-ci Jan 29, 2018
@jckarter jckarter force-pushed the generic-requirement-details branch from d9cec88 to a9955d6 Compare January 29, 2018 04:00
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@jckarter jckarter force-pushed the generic-requirement-details branch from c8c749a to c7e32d3 Compare January 29, 2018 15:09
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@jckarter jckarter force-pushed the generic-requirement-details branch from c7e32d3 to 64a2f49 Compare January 29, 2018 15:16
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swiftlang swiftlang deleted a comment from swift-ci Jan 29, 2018
@swiftlang swiftlang deleted a comment from swift-ci Jan 29, 2018
@swiftlang swiftlang deleted a comment from swift-ci Jan 29, 2018
@swiftlang swiftlang deleted a comment from swift-ci Jan 29, 2018
@swiftlang swiftlang deleted a comment from swift-ci Jan 29, 2018
@swiftlang swiftlang deleted a comment from swift-ci Jan 29, 2018
jckarter added a commit to jckarter/swift-xcode-playground-support that referenced this pull request Jan 29, 2018
@jckarter
Copy link
Contributor Author

Please test with the following pull request:
apple/swift-xcode-playground-support#19

@swift-ci Please test macOS

@jckarter
Copy link
Contributor Author

@swift-ci Please test source compatibility

@graydon
Copy link
Contributor

graydon commented Jan 29, 2018

Holy Toledo!

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 64a2f495dea4f21d051e2cd1a799677828cef18f

@jckarter jckarter force-pushed the generic-requirement-details branch from 64a2f49 to 7e08c1b Compare January 30, 2018 00:16
…ors.

This new format more efficiently represents existing information, while
more accurately encoding important information about nested generic
contexts with same-type and layout constraints that need to be evaluated
at runtime. It's also designed with an eye to forward- and
backward-compatible expansion for ABI stability with future Swift
versions.
@jckarter jckarter force-pushed the generic-requirement-details branch from 7e08c1b to a7a3b17 Compare January 30, 2018 02:25
@jckarter
Copy link
Contributor Author

Please test with the following pull request:
apple/swift-xcode-playground-support#19

@swift-ci Please test

@swiftlang swiftlang deleted a comment from swift-ci Jan 30, 2018
@jckarter jckarter merged commit fdef6ef into swiftlang:master Jan 30, 2018
jckarter added a commit to apple/swift-xcode-playground-support that referenced this pull request Jan 30, 2018
vedantk added a commit to vedantk/swift that referenced this pull request Jan 30, 2018
…irement-details"

This reverts commit fdef6ef, reversing
changes made to 9182327.
cwakamo added a commit to apple/swift-xcode-playground-support that referenced this pull request Jan 31, 2018
…ameManagementTestCase.

The changes for swiftlang/swift#13468 are not on every branch this test runs against.
Until that's rectified, disable the expectations to avoid blocking testing against the affected branches.
@jrose-apple
Copy link
Contributor

It looks like this has regressed the printing of local types. See discussion in SR-6787.

@jckarter
Copy link
Contributor Author

jckarter commented Feb 5, 2018

It changes it; I wouldn't say it's a regression.

iOSdev0623 added a commit to iOSdev0623/xcode-playground-support that referenced this pull request Apr 28, 2022
iOSdev0623 added a commit to iOSdev0623/xcode-playground-support that referenced this pull request Apr 28, 2022
iOSdev0623 added a commit to iOSdev0623/xcode-playground-support that referenced this pull request Apr 28, 2022
…ameManagementTestCase.

The changes for swiftlang/swift#13468 are not on every branch this test runs against.
Until that's rectified, disable the expectations to avoid blocking testing against the affected branches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants