[4.1][Parse] Disable token receiver while parsing types in editor placeholder #13480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, for `<#T##Type#>`, `TokReceiver` records
`{'<#T##Type#>', 'Type'}`.
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: The parser has
TokReceiverfor recording consumed tokens used by SourceKit. When the parser parses types in editor placeholder (e.g.<#T##String#>), it should stop the recording so it doesn't record extra tokens following to the placeholder. Although those extra tokens were usually just ignored, if the placeholder was at the end of the file, it used to cause a SourceKit crash.Scope: Affects SourceKit for files which has placeholder at the end of it.
Issue: rdar://problem/36081659
Risk: Low,
TokReceiveris disabled in normal compilation.Testing: Added compiler regression test.