Update the metadata-initialization ABI #13570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test. |
|
Build failed |
rjmccall
force-pushed
the
metadata-init-abi
branch
from
1d68218 to
2681a6d
Compare
|
@swift-ci Please test. |
1 similar comment
|
@swift-ci Please test. |
|
Build failed |
|
Build failed |
rjmccall
force-pushed
the
metadata-init-abi
branch
from
2681a6d to
d0249ce
Compare
|
Missed the fact that the micro-stdlib provided a stub for initEnumValueWitnessTable. |
|
@swift-ci Please test. |
1 similar comment
|
@swift-ci Please test. |
|
Build failed |
- Create the value witness table as a separate global object instead of concatenating it to the metadata pattern. - Always pass the metadata to the runtime and let the runtime handle instantiating or modifying the value witness table. - Pass the right layout algorithm version to the runtime; currently this is always "Swift 5". - Create a runtime function to instantiate single-case enums. Among other things, this makes the copying of the VWT, and any modifications of it, explicit and in the runtime, which is more future-proof.
rjmccall
force-pushed
the
metadata-init-abi
branch
from
d0249ce to
9bbbe2c
Compare
|
@swift-ci Please smoke test and merge. |
1 similar comment
|
@swift-ci Please smoke test and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the metadata-initialization ABI:
Create the value witness table as a separate global object instead of concatenating it to the metadata pattern.
Always pass the metadata to the runtime and let the runtime handle instantiating or modifying the value witness table.
Pass the right layout algorithm version to the runtime; currently this is always "Swift 5".
Create a runtime function to instantiate single-case enums.
Among other things, this makes the copying of the VWT, and any modifications of it, explicit and in the runtime, which is more future-proof.