Skip to content

Class resilience part 9 #13618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 25, 2017

Conversation

slavapestov
Copy link
Contributor

No description provided.

@slavapestov slavapestov requested a review from rjmccall December 25, 2017 04:41
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 9e7cd8a5da3324b820ece1bb0db72620d68ea435

@slavapestov slavapestov force-pushed the class-resilience-part-9 branch from 9e7cd8a to 0103cf6 Compare December 25, 2017 08:02
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

1 similar comment
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 9e7cd8a5da3324b820ece1bb0db72620d68ea435

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 9e7cd8a5da3324b820ece1bb0db72620d68ea435

@slavapestov slavapestov merged commit db6b911 into swiftlang:master Dec 25, 2017
@rjmccall
Copy link
Contributor

rjmccall commented Jan 3, 2018

This looks good. An alternative approach would be to always store offsets relative to the start of the class's metadata section, but I guess that would require us to dirty more memory during initialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants