[Parse] Small cleanups in parseBraceItems() #13620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reorder 'if ... else if' branches to simplify conditions.
* use 'append()' instead of `for { push_back() }`
Removed from 'parseTopLevel()'. There's no particular reason to diagnose it in 'parseTopLevel()'.
|
@swift-ci Please test |
|
@DougGregor Please post-commit review this if you have chance. |
DougGregor
reviewed
Dec 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if ... else ifbranches to simplify conditions.SmallVectorImpl::append()instead offor { push_back() }skipExtraTopLevelRBraces(). Removed it fromparseTopLevel(). There's no particular reason to diagnose it inparseTopLevel().