[SIL] NFC: remove TailAllocatedOperandList template #13628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor UnaryInstructionWithTypeDependentOperandsBase into two template classes, where the original template now subclasses a simpler template called "InstructionBaseWithTrailingObjects".
Also, repack misc bits and stop hard coding the number of fixed operands.
Please use InstructionBaseWithTrailingOperands template now. It is more type safe and more space efficient.
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
InstructionBaseWithTrailingOperandsto wrapllvm::TrailingObjectsand removeTailAllocatedOperandList, which is less safe, less feature rich, and less space efficient when compared to the LLVM type. This new template also helps automate boilerplate logic likegetAllOperands()andOperanddestruction.