Skip to content

[Type checker] Make redeclaration checking validate fewer declarations. #13643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2018
Merged

[Type checker] Make redeclaration checking validate fewer declarations. #13643

merged 1 commit into from
Jan 1, 2018

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Dec 29, 2017 •
edited
Loading

Redeclaration checking was validating all declarations with the same
base name as the given declaration (and in the same general nominal
type), even when it was trivial to determine that the declarations
could not be conflicting. Separate out the easy structural checks
(based on kind, full name, instance vs. non-instance member, etc.) and
perform those first, before validation.

Fixes SR-6558 / rdar://problem/36068194, a case where
redeclaration checking caused some unnecessary recursion in the type
checker.

@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor
Copy link
Member Author

@swift-ci please test source compatibility

@DougGregor
Copy link
Member Author

@swift-ci please test compiler performance

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b0a6cea0ba28e5054333d3741e379a901089594a

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b0a6cea0ba28e5054333d3741e379a901089594a

@swift-ci
Copy link
Contributor

Build comment file:

Summary for master full

Unexpected test results, stats may be off for FAIL_Kronos-Kronos.xcodeproj_3.0_BuildXcodeProjectTarget_Kronos_generic-platform-tvOS.log, FAIL_RxDataSources-Pods-Pods.xcodeproj_3.0_BuildXcodeProjectTarget_Pods-RxDataSources_generic-platform-iOS.log, FAIL_Kronos-Kronos.xcodeproj_3.0_BuildXcodeProjectTarget_Kronos_generic-platform-iOS.log, FAIL_Dollar-Dollar.xcodeproj_3.0_BuildXcodeProjectScheme_Dollar_generic-platform-macOS.log, 3, FAIL_Kronos-Kronos.xcodeproj_3.0_BuildXcodeProjectTarget_Kronos_generic-platform-macOS.log, FAIL_RxDataSources-Pods-Pods.xcodeproj_3.0_BuildXcodeProjectTarget_Pods-Example_generic-platform-iOS.log

No regressions above thresholds

Debug

debug brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 964,142,004 964,141,889 -115 -0.0%
time.swift-driver.wall 1365.5s 1362.5s -3.0s -0.22%

debug detailed

Regressed (0)
name old new delta delta_pct
Improved (2)
name old new delta delta_pct
Sema.NumDeclsValidated 2,052,730 2,022,827 -29,903 -1.46% ✅
Sema.NumTypesValidated 4,716,187 4,556,683 -159,504 -3.38% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (21)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 1,603,286 1,602,223 -1,063 -0.07%
AST.NumLoadedModules 316,892 316,892 0 0.0%
AST.NumTotalClangImportedEntities 5,033,692 5,032,735 -957 -0.02%
AST.NumUsedConformances 147,961 147,961 0 0.0%
IRModule.NumIRBasicBlocks 3,023,933 3,023,933 0 0.0%
IRModule.NumIRFunctions 1,451,827 1,451,827 0 0.0%
IRModule.NumIRGlobals 1,366,867 1,366,867 0 0.0%
IRModule.NumIRInsts 31,297,525 31,297,525 0 0.0%
IRModule.NumIRValueSymbols 2,403,428 2,403,428 0 0.0%
LLVM.NumLLVMBytesOutput 964,142,004 964,141,889 -115 -0.0%
SILModule.NumSILGenFunctions 682,116 682,116 0 0.0%
SILModule.NumSILOptFunctions 1,353,820 1,353,820 0 0.0%
Sema.NumConformancesDeserialized 5,964,069 5,962,457 -1,612 -0.03%
Sema.NumConstraintScopes 14,989,778 14,989,638 -140 -0.0%
Sema.NumDeclsDeserialized 47,616,527 47,607,966 -8,561 -0.02%
Sema.NumFunctionsTypechecked 965,017 964,467 -550 -0.06%
Sema.NumGenericSignatureBuilders 1,534,987 1,528,496 -6,491 -0.42%
Sema.NumLazyGenericEnvironments 9,428,676 9,425,530 -3,146 -0.03%
Sema.NumLazyGenericEnvironmentsLoaded 864,318 864,145 -173 -0.02%
Sema.NumLazyIterableDeclContexts 7,338,258 7,334,709 -3,549 -0.05%
Sema.NumTypesDeserialized 49,883,834 49,871,257 -12,577 -0.03%

Debug-opt

debug-opt brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 935,832,876 935,440,225 -392,651 -0.04%
time.swift-driver.wall 2473.8s 2463.2s -10.5s -0.42%

debug-opt detailed

Regressed (0)
name old new delta delta_pct
Improved (2)
name old new delta delta_pct
Sema.NumDeclsValidated 2,045,950 2,012,935 -33,015 -1.61% ✅
Sema.NumTypesValidated 4,706,049 4,541,845 -164,204 -3.49% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (21)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 1,600,168 1,597,521 -2,647 -0.17%
AST.NumLoadedModules 304,444 304,214 -230 -0.08%
AST.NumTotalClangImportedEntities 5,308,083 5,303,155 -4,928 -0.09%
AST.NumUsedConformances 147,625 147,457 -168 -0.11%
IRModule.NumIRBasicBlocks 2,866,911 2,865,633 -1,278 -0.04%
IRModule.NumIRFunctions 1,140,128 1,139,581 -547 -0.05%
IRModule.NumIRGlobals 1,215,683 1,215,247 -436 -0.04%
IRModule.NumIRInsts 23,798,510 23,789,695 -8,815 -0.04%
IRModule.NumIRValueSymbols 2,039,041 2,038,148 -893 -0.04%
LLVM.NumLLVMBytesOutput 935,832,876 935,440,225 -392,651 -0.04%
SILModule.NumSILGenFunctions 680,364 680,006 -358 -0.05%
SILModule.NumSILOptFunctions 1,978,430 1,977,640 -790 -0.04%
Sema.NumConformancesDeserialized 11,303,347 11,296,096 -7,251 -0.06%
Sema.NumConstraintScopes 14,968,230 14,957,309 -10,921 -0.07%
Sema.NumDeclsDeserialized 52,571,396 52,517,303 -54,093 -0.1%
Sema.NumFunctionsTypechecked 962,704 961,002 -1,702 -0.18%
Sema.NumGenericSignatureBuilders 1,574,298 1,566,241 -8,057 -0.51%
Sema.NumLazyGenericEnvironments 10,254,097 10,240,967 -13,130 -0.13%
Sema.NumLazyGenericEnvironmentsLoaded 876,725 875,616 -1,109 -0.13%
Sema.NumLazyIterableDeclContexts 7,598,052 7,587,462 -10,590 -0.14%
Sema.NumTypesDeserialized 57,360,510 57,297,658 -62,852 -0.11%

Wmo-onone

wmo-onone brief

Regressed (0)
name old new delta delta_pct
Improved (1)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 862,714,792 851,122,572 -11,592,220 -1.34% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (1)
name old new delta delta_pct
time.swift-driver.wall 1349.1s 1339.2s -9.9s -0.73%

wmo-onone detailed

Regressed (0)
name old new delta delta_pct
Improved (3)
name old new delta delta_pct
IRModule.NumIRGlobals 1,188,596 1,175,955 -12,641 -1.06% ✅
LLVM.NumLLVMBytesOutput 862,714,792 851,122,572 -11,592,220 -1.34% ✅
Sema.NumDeclsValidated 893,895 883,188 -10,707 -1.2% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (20)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 185,616 184,854 -762 -0.41%
AST.NumLoadedModules 10,687 10,687 0 0.0%
AST.NumTotalClangImportedEntities 606,476 605,317 -1,159 -0.19%
AST.NumUsedConformances 151,590 151,476 -114 -0.08%
IRModule.NumIRBasicBlocks 2,596,169 2,580,656 -15,513 -0.6%
IRModule.NumIRFunctions 1,273,059 1,263,502 -9,557 -0.75%
IRModule.NumIRInsts 28,966,002 28,836,824 -129,178 -0.45%
IRModule.NumIRValueSymbols 2,126,767 2,106,661 -20,106 -0.95%
SILModule.NumSILGenFunctions 469,744 467,016 -2,728 -0.58%
SILModule.NumSILOptFunctions 562,804 559,478 -3,326 -0.59%
Sema.NumConformancesDeserialized 1,279,222 1,274,184 -5,038 -0.39%
Sema.NumConstraintScopes 14,268,730 14,264,768 -3,962 -0.03%
Sema.NumDeclsDeserialized 4,426,349 4,414,177 -12,172 -0.27%
Sema.NumFunctionsTypechecked 286,611 286,341 -270 -0.09%
Sema.NumGenericSignatureBuilders 153,265 153,102 -163 -0.11%
Sema.NumLazyGenericEnvironments 759,461 757,915 -1,546 -0.2%
Sema.NumLazyGenericEnvironmentsLoaded 95,441 95,241 -200 -0.21%
Sema.NumLazyIterableDeclContexts 489,865 489,100 -765 -0.16%
Sema.NumTypesDeserialized 4,568,053 4,554,009 -14,044 -0.31%
Sema.NumTypesValidated 1,059,360 1,059,270 -90 -0.01%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (1)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 930,493,626 919,241,242 -11,252,384 -1.21% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (1)
name old new delta delta_pct
time.swift-driver.wall 2907.8s 2888.2s -19.6s -0.68%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 930,493,626 919,241,242 -11,252,384 -1.21% ✅
Sema.NumDeclsValidated 1,106,651 1,093,470 -13,181 -1.19% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (21)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 470,907 469,921 -986 -0.21%
AST.NumLoadedModules 58,218 58,218 0 0.0%
AST.NumTotalClangImportedEntities 1,597,674 1,596,131 -1,543 -0.1%
AST.NumUsedConformances 154,822 154,708 -114 -0.07%
IRModule.NumIRBasicBlocks 2,766,905 2,754,874 -12,031 -0.43%
IRModule.NumIRFunctions 1,142,184 1,135,196 -6,988 -0.61%
IRModule.NumIRGlobals 1,276,918 1,265,527 -11,391 -0.89%
IRModule.NumIRInsts 24,098,939 24,010,303 -88,636 -0.37%
IRModule.NumIRValueSymbols 2,090,880 2,074,192 -16,688 -0.8%
SILModule.NumSILGenFunctions 507,376 504,651 -2,725 -0.54%
SILModule.NumSILOptFunctions 997,600 992,880 -4,720 -0.47%
Sema.NumConformancesDeserialized 3,854,051 3,837,881 -16,170 -0.42%
Sema.NumConstraintScopes 14,564,770 14,560,720 -4,050 -0.03%
Sema.NumDeclsDeserialized 13,304,765 13,289,381 -15,384 -0.12%
Sema.NumFunctionsTypechecked 420,303 419,921 -382 -0.09%
Sema.NumGenericSignatureBuilders 466,033 465,422 -611 -0.13%
Sema.NumLazyGenericEnvironments 2,491,191 2,489,257 -1,934 -0.08%
Sema.NumLazyGenericEnvironmentsLoaded 241,838 241,599 -239 -0.1%
Sema.NumLazyIterableDeclContexts 1,834,768 1,833,649 -1,119 -0.06%
Sema.NumTypesDeserialized 14,958,624 14,935,554 -23,070 -0.15%
Sema.NumTypesValidated 2,034,551 2,025,512 -9,039 -0.44%

@DougGregor
[Type checker] Make redeclaration checking validate fewer declarations.
8b58b0d 
Redeclaration checking was validating all declarations with the same
base name as the given declaration (and in the same general nominal
type), even when it was trivial to determine that the declarations
could not be conflicting. Separate out the easy structural checks
(based on kind, full name, instance vs. non-instance member, etc.) and
perform those first, before validation.

Fixes SR-6558, a case where redeclaration checking caused some
unnecessary recursion in the type checker.
@DougGregor DougGregor force-pushed the redecl-fewer-validations branch from b0a6cea to 8b58b0d Compare December 31, 2017 07:28
@DougGregor
Copy link
Member Author

@swift-ci please test

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor
Copy link
Member Author

@swift-ci please test source compatibility

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please test source compatibility

@DougGregor
Copy link
Member Author

@swift-ci please test compiler performance

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please test compiler performance

@swift-ci
Copy link
Contributor

Build comment file:

Summary for master full

Unexpected test results, stats may be off for FAIL_Kronos-Kronos.xcodeproj_3.0_BuildXcodeProjectTarget_Kronos_generic-platform-tvOS.log, FAIL_RxDataSources-Pods-Pods.xcodeproj_3.0_BuildXcodeProjectTarget_Pods-RxDataSources_generic-platform-iOS.log, FAIL_Kronos-Kronos.xcodeproj_3.0_BuildXcodeProjectTarget_Kronos_generic-platform-iOS.log, FAIL_Dollar-Dollar.xcodeproj_3.0_BuildXcodeProjectScheme_Dollar_generic-platform-macOS.log, 3, FAIL_Kronos-Kronos.xcodeproj_3.0_BuildXcodeProjectTarget_Kronos_generic-platform-macOS.log, FAIL_RxDataSources-Pods-Pods.xcodeproj_3.0_BuildXcodeProjectTarget_Pods-Example_generic-platform-iOS.log

No regressions above thresholds

Debug

debug brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 964,142,005 964,141,885 -120 -0.0%
time.swift-driver.wall 1362.9s 1361.1s -1.8s -0.13%

debug detailed

Regressed (0)
name old new delta delta_pct
Improved (2)
name old new delta delta_pct
Sema.NumDeclsValidated 2,052,730 2,022,825 -29,905 -1.46% ✅
Sema.NumTypesValidated 4,716,187 4,556,683 -159,504 -3.38% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (21)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 1,603,286 1,602,223 -1,063 -0.07%
AST.NumLoadedModules 316,892 316,892 0 0.0%
AST.NumTotalClangImportedEntities 5,033,692 5,032,735 -957 -0.02%
AST.NumUsedConformances 147,961 147,961 0 0.0%
IRModule.NumIRBasicBlocks 3,023,933 3,023,933 0 0.0%
IRModule.NumIRFunctions 1,451,827 1,451,827 0 0.0%
IRModule.NumIRGlobals 1,366,867 1,366,867 0 0.0%
IRModule.NumIRInsts 31,297,525 31,297,525 0 0.0%
IRModule.NumIRValueSymbols 2,403,428 2,403,428 0 0.0%
LLVM.NumLLVMBytesOutput 964,142,005 964,141,885 -120 -0.0%
SILModule.NumSILGenFunctions 682,116 682,116 0 0.0%
SILModule.NumSILOptFunctions 1,353,820 1,353,820 0 0.0%
Sema.NumConformancesDeserialized 5,963,761 5,962,108 -1,653 -0.03%
Sema.NumConstraintScopes 14,989,778 14,989,210 -568 -0.0%
Sema.NumDeclsDeserialized 47,616,403 47,607,812 -8,591 -0.02%
Sema.NumFunctionsTypechecked 965,017 964,467 -550 -0.06%
Sema.NumGenericSignatureBuilders 1,534,987 1,528,496 -6,491 -0.42%
Sema.NumLazyGenericEnvironments 9,428,676 9,425,530 -3,146 -0.03%
Sema.NumLazyGenericEnvironmentsLoaded 864,318 864,145 -173 -0.02%
Sema.NumLazyIterableDeclContexts 7,338,134 7,334,559 -3,575 -0.05%
Sema.NumTypesDeserialized 49,883,680 49,871,099 -12,581 -0.03%

Debug-opt

debug-opt brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 935,692,750 935,899,624 206,874 0.02%
time.swift-driver.wall 2468.6s 2464.3s -4.3s -0.17%

debug-opt detailed

Regressed (0)
name old new delta delta_pct
Improved (2)
name old new delta delta_pct
Sema.NumDeclsValidated 2,044,255 2,016,230 -28,025 -1.37% ✅
Sema.NumTypesValidated 4,703,515 4,546,791 -156,724 -3.33% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (21)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 1,599,350 1,599,156 -194 -0.01%
AST.NumLoadedModules 304,304 304,494 190 0.06%
AST.NumTotalClangImportedEntities 5,305,805 5,307,732 1,927 0.04%
AST.NumUsedConformances 147,541 147,625 84 0.06%
IRModule.NumIRBasicBlocks 2,866,401 2,867,042 641 0.02%
IRModule.NumIRFunctions 1,139,853 1,140,125 272 0.02%
IRModule.NumIRGlobals 1,215,463 1,215,693 230 0.02%
IRModule.NumIRInsts 23,795,640 23,800,083 4,443 0.02%
IRModule.NumIRValueSymbols 2,038,590 2,039,047 457 0.02%
LLVM.NumLLVMBytesOutput 935,692,750 935,899,624 206,874 0.02%
SILModule.NumSILGenFunctions 680,185 680,364 179 0.03%
SILModule.NumSILOptFunctions 1,978,018 1,978,414 396 0.02%
Sema.NumConformancesDeserialized 11,300,204 11,301,416 1,212 0.01%
Sema.NumConstraintScopes 14,962,832 14,967,676 4,844 0.03%
Sema.NumDeclsDeserialized 52,548,538 52,562,853 14,315 0.03%
Sema.NumFunctionsTypechecked 962,133 962,144 11 0.0%
Sema.NumGenericSignatureBuilders 1,573,491 1,567,846 -5,645 -0.36%
Sema.NumLazyGenericEnvironments 10,249,115 10,250,931 1,816 0.02%
Sema.NumLazyGenericEnvironmentsLoaded 876,257 876,552 295 0.03%
Sema.NumLazyIterableDeclContexts 7,594,424 7,594,557 133 0.0%
Sema.NumTypesDeserialized 57,335,282 57,347,645 12,363 0.02%

Wmo-onone

wmo-onone brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 862,714,792 862,714,848 56 0.0%
time.swift-driver.wall 1340.2s 1339.3s -862.7ms -0.06%

wmo-onone detailed

Regressed (0)
name old new delta delta_pct
Improved (1)
name old new delta delta_pct
Sema.NumDeclsValidated 893,895 883,616 -10,279 -1.15% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (22)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 185,616 185,616 0 0.0%
AST.NumLoadedModules 10,687 10,687 0 0.0%
AST.NumTotalClangImportedEntities 606,476 606,476 0 0.0%
AST.NumUsedConformances 151,590 151,590 0 0.0%
IRModule.NumIRBasicBlocks 2,596,169 2,596,169 0 0.0%
IRModule.NumIRFunctions 1,273,059 1,273,059 0 0.0%
IRModule.NumIRGlobals 1,188,596 1,188,596 0 0.0%
IRModule.NumIRInsts 28,966,002 28,966,002 0 0.0%
IRModule.NumIRValueSymbols 2,126,767 2,126,767 0 0.0%
LLVM.NumLLVMBytesOutput 862,714,792 862,714,848 56 0.0%
SILModule.NumSILGenFunctions 469,744 469,744 0 0.0%
SILModule.NumSILOptFunctions 562,804 562,804 0 0.0%
Sema.NumConformancesDeserialized 1,279,070 1,279,070 0 0.0%
Sema.NumConstraintScopes 14,268,730 14,268,730 0 0.0%
Sema.NumDeclsDeserialized 4,426,323 4,426,401 78 0.0%
Sema.NumFunctionsTypechecked 286,611 286,611 0 0.0%
Sema.NumGenericSignatureBuilders 153,265 153,265 0 0.0%
Sema.NumLazyGenericEnvironments 759,461 759,474 13 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 95,441 95,441 0 0.0%
Sema.NumLazyIterableDeclContexts 489,839 489,847 8 0.0%
Sema.NumTypesDeserialized 4,567,977 4,567,604 -373 -0.01%
Sema.NumTypesValidated 1,059,360 1,059,360 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 930,534,165 930,534,248 83 0.0%
time.swift-driver.wall 2909.8s 2896.4s -13.4s -0.46%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (1)
name old new delta delta_pct
Sema.NumDeclsValidated 1,105,084 1,093,898 -11,186 -1.01% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (22)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 470,811 470,683 -128 -0.03%
AST.NumLoadedModules 58,212 58,218 6 0.01%
AST.NumTotalClangImportedEntities 1,597,327 1,597,554 227 0.01%
AST.NumUsedConformances 154,594 154,822 228 0.15%
IRModule.NumIRBasicBlocks 2,766,978 2,766,978 0 0.0%
IRModule.NumIRFunctions 1,142,198 1,142,198 0 0.0%
IRModule.NumIRGlobals 1,276,919 1,276,919 0 0.0%
IRModule.NumIRInsts 24,100,451 24,100,451 0 0.0%
IRModule.NumIRValueSymbols 2,090,893 2,090,893 0 0.0%
LLVM.NumLLVMBytesOutput 930,534,165 930,534,248 83 0.0%
SILModule.NumSILGenFunctions 507,376 507,376 0 0.0%
SILModule.NumSILOptFunctions 997,607 997,607 0 0.0%
Sema.NumConformancesDeserialized 3,853,128 3,853,763 635 0.02%
Sema.NumConstraintScopes 14,553,828 14,564,658 10,830 0.07%
Sema.NumDeclsDeserialized 13,301,710 13,303,884 2,174 0.02%
Sema.NumFunctionsTypechecked 419,819 420,191 372 0.09%
Sema.NumGenericSignatureBuilders 465,861 465,625 -236 -0.05%
Sema.NumLazyGenericEnvironments 2,490,604 2,491,045 441 0.02%
Sema.NumLazyGenericEnvironmentsLoaded 241,752 241,818 66 0.03%
Sema.NumLazyIterableDeclContexts 1,834,385 1,834,505 120 0.01%
Sema.NumTypesDeserialized 14,955,597 14,956,681 1,084 0.01%
Sema.NumTypesValidated 2,033,190 2,025,602 -7,588 -0.37%

@DougGregor DougGregor merged commit b11d544 into swiftlang:master Jan 1, 2018
@DougGregor DougGregor deleted the redecl-fewer-validations branch January 1, 2018 04:20
@DougGregor DougGregor mentioned this pull request Jan 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DougGregor @swift-ci