Skip to content

Implement a few silcombine transformations for arrays #13652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 31, 2017
Merged

Implement a few silcombine transformations for arrays #13652

merged 2 commits into from
Dec 31, 2017

Conversation

lattner
Copy link
Contributor

@lattner lattner commented Dec 31, 2017

  • Useless existential_ref <-> class conversions.
  • mark_dependence_inst depending on uninteresting instructions.
  • release(init_existential_ref(x)) -> release(x) when hasOneUse(x)
  • Update COWArrayOpt to handle the new forms generated by this.

these aren't massive performance wins, but do shrink the size of SIL when
dealing with arrays.

This updates and subsumes PR 12338

@lattner
Implement a few silcombine transformations for arrays
93c57f8 
 - Useless existential_ref <-> class conversions.
 - mark_dependence_inst depending on uninteresting instructions.
 - release(init_existential_ref(x)) -> release(x) when hasOneUse(x)
 - Update COWArrayOpt to handle the new forms generated by this.

these aren't massive performance wins, but do shrink the size of SIL when
dealing with arrays.
@lattner
Copy link
Contributor Author

lattner commented Dec 31, 2017

@swift-ci please test and merge

@lattner
Copy link
Contributor Author

lattner commented Dec 31, 2017

@swift-ci please test

@gottesmm
Copy link
Contributor

@swift-ci test

@gottesmm
Copy link
Contributor

@lattner there is a bug in the CI system where after you do a force push, you need to ask it to test twice.

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 93c57f8

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 93c57f8

@gottesmm
Copy link
Contributor

(I think my 2nd test command caused it to work around the issue).

@lattner
Copy link
Contributor Author

lattner commented Dec 31, 2017

Thank you for the help @gottesmm!

@lattner lattner merged commit de28975 into swiftlang:master Dec 31, 2017
@lattner lattner deleted the array-silcombines branch December 31, 2017 06:30
@bob-wilson
Copy link
Contributor

There is a new assertion failure on the oss-swift_tools-RA_stdlib-RD_test-simulator bot (https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RD_test-simulator/524/) and this PR is the only thing on the blame list. @lattner can you please take a look?

@lattner
Copy link
Contributor Author

lattner commented Jan 1, 2018

Sure, taking a look @bob-wilson

@lattner
Copy link
Contributor Author

lattner commented Jan 1, 2018

I can't repro this @bob-wilson, but hopefully PR 13656 will fix this.

@lattner
Copy link
Contributor Author

lattner commented Jan 2, 2018

Just to close the loop on this, oss-swift_tools-RA_stdlib-RD_test-simulator is back to happiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lattner @gottesmm @swift-ci @bob-wilson